Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advance RFC #0830 "Evolving Ember's Major Version Process" to Stage Ready for Release #878

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

emberjs-rfcs-bot
Copy link
Collaborator

@emberjs-rfcs-bot emberjs-rfcs-bot commented Dec 1, 2022

Advance #830 to the Ready For Release Stage

Summary

This pull request is advancing the RFC to the Ready For Release Stage.

An FCP is required before merging this PR to advance.

Upon merging this PR, automation will open a draft PR for this RFC to move to the Released Stage.

Ready for Release Stage Description

This stage is complete when the implementation is complete according to plan outlined in the RFC, and is in harmony with any changes in Ember that have occurred since the RFC was first written. This includes any necessary learning materials. At this stage, features or deprecations may be available for use behind a feature flag, or with an optional package, etc.

For codebase changes, there are no open questions that are anticipated to require breaking changes; the Ember team is ready to commit to the stability of any interfaces exposed by the current implementation of the feature.

This stage should include a list of criteria for determining when the proposal can be considered Recommended after being Released.

An FCP is required to move into this stage.

Each Ember core team will be requested as a reviewer on the PR to move into this stage. A representative of each team adds a review. If a team does not respond to the request, and after the conclusion of the FCP, it is assumed that the release may proceed.

Checklist to move to Ready for Release

  • Implementation is complete according to plan outlined in the RFC, with any adjustments noted in the RFC
  • Any necessary learning materials have been updated
  • The Ember team is ready to commit to the stability of any interfaces exposed by the current implementation of the feature
  • Criteria for moving to the Recommended Stage has been filled out
  • This PR has been converted from a draft to a regular PR and the Final Comment Period label has been added to start the FCP
  • Each team has been added as a reviewer to the PR at the start of the FCP
    • Framework @emberjs/framework
    • Data @emberjs/ember-data-core
    • CLI @emberjs/cli
    • Learning @emberjs/learning-core
    • Typescript @emberjs/typescript-core
    • Steering @emberjs/steering

Criteria for moving to Recommended (required)

A set of criteria for moving this RFC to the Recommended Stage, following release:

  1. Document for developers how to add a deprecation and test/flag it.

Track Implementation

<-- Use this section to track implementation of the RFC -->

@emberjs-rfcs-bot emberjs-rfcs-bot added RFC Advancement S-Ready for Release PR to move to the Ready for Release Stage labels Dec 1, 2022
@kategengler kategengler changed the title Advance RFC #0830 to Stage Ready for Release Advance RFC #0830 "Evolving Ember's Major Version Process" to Stage Ready for Release Feb 9, 2023
@ef4
Copy link
Contributor

ef4 commented Sep 29, 2023

The work here is to make ember's deprecation infrastructure automatically convert warnings into errors when you cross the until boundary of a deprecation.

@ef4
Copy link
Contributor

ef4 commented Mar 29, 2024

Latest update:

  • ember-source feature landed
  • ember-cli needs similar work

@ef4
Copy link
Contributor

ef4 commented Nov 8, 2024

Progress in ember-cli: ember-cli/ember-cli#10536

@ef4 ef4 requested review from a team November 22, 2024 20:12
@ef4 ef4 marked this pull request as ready for review November 22, 2024 20:13
@ef4
Copy link
Contributor

ef4 commented Nov 22, 2024

The last feature landed in ember-cli, so advancing this.

@chriskrycho
Copy link
Contributor

Congrats to everyone who did the work to make this a reality!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Final Comment Period RFC Advancement S-Ready for Release PR to move to the Ready for Release Stage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants